Skip to content

Commit

Permalink
Fix go_path link mode
Browse files Browse the repository at this point in the history
  • Loading branch information
fmeum committed May 17, 2023
1 parent 9a11878 commit a9b0299
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 12 deletions.
5 changes: 0 additions & 5 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ tasks:
- tests/core/cgo/generate_imported_dylib.sh
build_targets:
- "//..."
test_flags:
# Temporary rollback to fix //tests/core/go_path builds
# https://github.com/bazelbuild/continuous-integration/commit/a95a916098d3015bb4ea20b7e33bc7d27d00bffc
- "--remote_download_outputs=all"
- "--build_runfile_links"
test_targets:
- "//..."
ubuntu2004:
Expand Down
6 changes: 0 additions & 6 deletions .bazelrc
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
common --enable_platform_specific_config

# //tests/core/go_path is incompatible with BwoB, which is enabled in Bazel CI.
# https://github.com/bazelbuild/continuous-integration/commit/a95a916098d3015bb4ea20b7e33bc7d27d00bffc
build --remote_download_outputs=all
build --build_runfile_links
build --experimental_remote_download_regex=.*tests/core/go_path/.*

# Go requires a C toolchain that accepts options and emits errors like
# gcc or clang. The Go SDK does not support MSVC.
build:windows --cpu=x64_windows
Expand Down
2 changes: 1 addition & 1 deletion go/private/tools/path.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def _go_path_impl(ctx):
# Declare individual outputs in link mode. Symlinks can't point outside
# tree artifacts.
outputs = [
ctx.actions.declare_file(ctx.label.name + "/" + e.dst)
ctx.actions.declare_symlink(ctx.label.name + "/" + e.dst)
for e in manifest_entries
]
tag = ctx.actions.declare_file(ctx.label.name + "/.tag")
Expand Down

0 comments on commit a9b0299

Please sign in to comment.