Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define GOOS_<goos> and GOARCH_<goarch> for assembly #1894

Closed
jayconrod opened this issue Jan 9, 2019 · 1 comment · Fixed by #3528
Closed

Define GOOS_<goos> and GOARCH_<goarch> for assembly #1894

jayconrod opened this issue Jan 9, 2019 · 1 comment · Fixed by #3528
Labels
bug go

Comments

@jayconrod
Copy link
Contributor

go build does this. We should, too.

Example:

/opt/go1.12beta1/pkg/tool/linux_amd64/asm -trimpath $WORK/b001 -I $WORK/b001/ -I /opt/go1.12beta1/pkg/include -D GOOS_linux -D GOARCH_amd64 -o $WORK/b001/foo.o ./foo.s
@eugene-dounar
Copy link

eugene-dounar commented Sep 29, 2020 •
edited
Loading

Cannot build https://github.com/thrift-iterator/go due to this limitation. On of it's dependencies (https://github.com/v2pro/plz) relies on GOARCH_<goarch>

patrickmscott pushed a commit to patrickmscott/rules_go that referenced this issue Apr 11, 2023
@obs-gh-patrickscott
Add defines for assembly build
1bdd783 
Fixes bazelbuild#1894 by adding GOOS_
GOARCH_ and GOOS_GOARCH_ defines for building assembly.
@patrickmscott patrickmscott mentioned this issue Apr 11, 2023
Merged
patrickmscott pushed a commit to patrickmscott/rules_go that referenced this issue Apr 11, 2023
@obs-gh-patrickscott
Add defines for assembly build
097c7f9 
Fixes bazelbuild#1894 by adding GOOS_
GOARCH_ and GOOS_GOARCH_ defines for building assembly.
fmeum pushed a commit to patrickmscott/rules_go that referenced this issue Apr 13, 2023
@obs-gh-patrickscott @fmeum
Add defines for assembly build
fde3718 
Fixes bazelbuild#1894 by adding GOOS_
GOARCH_ and GOOS_GOARCH_ defines for building assembly.
fmeum pushed a commit that referenced this issue Apr 13, 2023
@patrickmscott @obs-gh-patrickscott
Add defines for assembly build (#3528)
3125d8f 
* Add defines for assembly build

Fixes #1894 by adding GOOS_
GOARCH_ and GOOS_GOARCH_ defines for building assembly.

* Return a copy of args

* Use build.Default variables for os and arch

Add a compilation test that uses another architecture with conditional
inclusion of an assembly function. This mimics a real library that fails
to build under rules_go.

---------

Co-authored-by: Patrick Scott <patrick.scott@observeinc.com>
linzhp pushed a commit that referenced this issue Apr 20, 2023
@patrickmscott @obs-gh-patrickscott @linzhp
Add defines for assembly build (#3528)
6dfed3d 
* Add defines for assembly build

Fixes #1894 by adding GOOS_
GOARCH_ and GOOS_GOARCH_ defines for building assembly.

* Return a copy of args

* Use build.Default variables for os and arch

Add a compilation test that uses another architecture with conditional
inclusion of an assembly function. This mimics a real library that fails
to build under rules_go.

---------

Co-authored-by: Patrick Scott <patrick.scott@observeinc.com>
tingilee pushed a commit to tingilee/rules_go that referenced this issue Jul 19, 2023
@patrickmscott @obs-gh-patrickscott
Add defines for assembly build (bazelbuild#3528)
6688163 
* Add defines for assembly build

Fixes bazelbuild#1894 by adding GOOS_
GOARCH_ and GOOS_GOARCH_ defines for building assembly.

* Return a copy of args

* Use build.Default variables for os and arch

Add a compilation test that uses another architecture with conditional
inclusion of an assembly function. This mimics a real library that fails
to build under rules_go.

---------

Co-authored-by: Patrick Scott <patrick.scott@observeinc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug go
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add defines for assembly build patrickmscott/rules_go
2 participants
@jayconrod @eugene-dounar