GoToolchainBinaryBuild leaves temp gopath dir (linux), or uploads to cache (windows)

[hauserx]

What version of rules_go are you using?

0.46.0

What version of gazelle are you using?

0.35.0

What version of Bazel are you using?

6.4

What operating system and processor architecture are you using?

Linux & Windows

What did you do?

Build anything with rules_go.

What did you see instead?

Each GoToolchainBinaryBuild execution leaves 2 entries like /tmp/tmp.CGmiYEaaeP/ under linux. Those correspond to throwaway cache created by mktemp -d that is never cleaned up:

rules_go/go/private/rules/binary.bzl

Line 462 in d45e218

cmd = "GOMAXPROCS=1 GOCACHE=$(mktemp -d) GOPATH=$(mktemp -d) {go} build -o {out} -trimpath -ldflags '{ldflags}' {srcs}".format(

Under Windows the same rule uses declare_directory to create space for cache and returns the declared directory from the rule, what causes uploading temporary gocache entries to remote cache and subsequent downloads.

rules_go/go/private/rules/binary.bzl

Line 440 in d45e218

gocache = ctx.actions.declare_directory("gocache")

Cache contains ~500 files / 50MB, which are not really problematic numbers as those action usually do not execute often (maybe other than in CI), but still those temporary files should be cleaned up.

[fmeum]

That assessment looks entirely correct.

Would you be interested in submitting a PR to fix one or both issues? Happy to review it!