Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Latin-1 workaround on Bazel 6.4.0+ #3872

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Remove Latin-1 workaround on Bazel 6.4.0+ #3872

merged 2 commits into from
Feb 26, 2024

Commits on Feb 26, 2024

  1. Remove Latin-1 workaround on Bazel 6.4.0+ 

    The fix for Latin-1 encoded files was landed in [6.4.0] after
being landed on Bazel [master].

We can conditionally use the old, unhermetic, `tar` workaround
on modern Bazel versions.

[master]: bazelbuild/bazel#18448
[6.4.0]: bazelbuild/bazel#19765
    @mattyclarkson
    mattyclarkson committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    ea2048c View commit details
    Browse the repository at this point in the history

  2. Use versions rather than bazel_features to avoid circular load pa… 

    …ttern

Due to the polyfilling of `bazel_features` to avoid double step loading in
`WORKSPACE`.
    @mattyclarkson
    mattyclarkson committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    70b10c6 View commit details
    Browse the repository at this point in the history