Skip to content

Commit

Permalink
chore: cleanup unused attributes for the host_toolchain repo rule (#2195
Browse files Browse the repository at this point in the history
)

The attributes were not used, so we can remove them for now.
  • Loading branch information
aignas committed Sep 13, 2024
1 parent c9972d3 commit 9b16bfb
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 16 deletions.
4 changes: 2 additions & 2 deletions examples/bzlmod/MODULE.bazel.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 1 addition & 6 deletions python/private/python_repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -692,12 +692,7 @@ def python_register_toolchains(
platform = platform,
))

host_toolchain(
name = name + "_host",
python_version = python_version,
user_repository_name = name,
platforms = loaded_platforms,
)
host_toolchain(name = name + "_host")

toolchain_aliases(
name = name,
Expand Down
8 changes: 0 additions & 8 deletions python/private/toolchains_repo.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -314,14 +314,6 @@ toolchain_aliases repo because referencing the `python` interpreter target from
this repo causes an eager fetch of the toolchain for the host platform.
""",
attrs = {
"platforms": attr.string_list(
doc = "List of platforms for which aliases shall be created",
),
"python_version": attr.string(doc = "The Python version."),
"user_repository_name": attr.string(
mandatory = True,
doc = "The base name for all created repositories, like 'python38'.",
),
"_rule_name": attr.string(default = "host_toolchain"),
"_rules_python_workspace": attr.label(default = Label("//:WORKSPACE")),
},
Expand Down

0 comments on commit 9b16bfb

Please sign in to comment.