-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simple test that the built and checked in PAR files match. #10
Conversation
@duggelz Let's see if Bazel CI thinks this is gonna work :) |
@damienmg what is going on here? |
Tests failed: http://ci.bazel.io/blue/organizations/jenkins/PR%2Frules_python/detail/rules_python/37/tests (fwiw Jenkins team is finally working on making it easier to mark the good step at failing). When you see the job Is yellow, that means that tests have failed and should have a test report somewhere). |
Hmm, @duggelz any sense for what might be making this non-deterministic? |
Doh. I was going to add a non-determinism test a while back but I couldn't get Bazel-in-bazel to work. Apparently I never filed a bug, and then it slipped off my radar. The non-determinism stems from the timestamps of the files inside the compressed archive. This is fixed in the internal tool by setting all timestamps to 12:00:01 AM, Jan 1, 1980 (there's a reason for this specific date). I will do the same. |
@duggelz At long last, this should be RFAL :) thanks for fixing this :D |
No description provided.