refactor(flags): return FeatureFlagInfo in --python_version flag #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
force-pushed
the
google.featflaginfo
branch
from
a92a8bb
to
0c75cb9
Compare
aignas
approved these changes
Aug 31, 2024
There was a problem hiding this comment.
Maybe we should note that we now return a FeatureFlag from the python version in the changelog. Rules_pycross had this implemented on top of rules_python, so maybe now it is possible to reduce the duplication?
Edit: unqueued the PR in case you would like to add the changelog item.
|
Added to changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
--python_versionflag also return theFeatureFlagInfoprovider.There are two reasons to also return the FeatureFlagInfo provider:
First, it allows the flag implementation to change the value and have that value respected
by config_setting() later. This allows, for example, the rule to use custom logic (and
information from things it depends on) to determine the effective flag value.
Secondly, it makes the flag compatible with the Google fork of this rule, which is
implemented using FeatureFlagInfo, to help eventually converge them.
Along the way, add config_common to the Sphinx Bazel inventory.