refactor(toolchains): split the implementation of toolchain rules to separate files #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
approved these changes
Sep 19, 2024
Comment on lines
+22
to
+23
| def is_standalone_interpreter(rctx, python_interpreter_path, *, logger = None): | ||
| """Query a python interpreter target for whether or not it's a rules_rust provided toolchain |
There was a problem hiding this comment.
Do you happen to know the history of this function? It's always struck me as a bit strange.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the dependency management in WORKSPACE much easier to do.
Summary:
Work towards #2081.