Skip to content

Commit

Permalink
Set output_files on the toolchain
Browse files Browse the repository at this point in the history
This avoids having to use the deprecated argument to `proto_common.compile`.

PiperOrigin-RevId: 547475903
  • Loading branch information
thomasvl authored and swiple-rules-gardener committed Jul 12, 2023
1 parent f681717 commit d0254af
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 1 addition & 0 deletions swift/internal/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ proto_lang_toolchain(
name = "proto_swift_toolchain",
command_line = "--swift_out=$(OUT)",
mnemonic = "ProtocGenSwift",
output_files = "multiple",
plugin = "@com_github_apple_swift_protobuf//:ProtoCompilerPlugin",
plugin_format_flag = "--plugin=protoc-gen-swift=%s",
progress_message = "Generating Swift sources for %{label}",
Expand Down
2 changes: 0 additions & 2 deletions swift/internal/swift_protoc_gen_aspect.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,6 @@ def _swift_protoc_gen_aspect_impl(target, aspect_ctx):
additional_inputs = depset(direct = [transitive_module_mapping_file]),
experimental_exec_group = _GENERATE_EXEC_GROUP,
generated_files = pbswift_files,
# ??? Docs says this is deprecated, but seems to be required
plugin_output = aspect_ctx.bin_dir.path,
proto_info = target_proto_info,
proto_lang_toolchain_info = proto_lang_toolchain_info,
)
Expand Down

0 comments on commit d0254af

Please sign in to comment.