Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1361 Chore: refactor emissions intensity schema #1716

Closed
wants to merge 111 commits into from
Closed

1361 Chore: refactor emissions intensity schema #1716

wants to merge 111 commits into from

Conversation

BCerki
Copy link
Collaborator

@BCerki BCerki commented Jun 8, 2023 •
edited
Loading

card: https://app.zenhub.com/workspaces/climate-action-secretariat-60ca4121764d710011481ca2/issues/gh/bcgov/cas-cif/1361

A couple notes:

@BCerki BCerki force-pushed the 1361-refactor-emissions-intensity-schema branch 6 times, most recently from 9e80ec8 to 544f7fc Compare June 14, 2023 21:23
@BCerki BCerki force-pushed the 1361-refactor-emissions-intensity-schema branch from 5f59e96 to 85bd034 Compare June 19, 2023 15:50
Sepehr-Sobhani and others added 22 commits June 19, 2023 09:48
@Sepehr-Sobhani
Merge pull request #1733 from bcgov/1582-2-preview-revision
4d23aee 
Chore: 1582 change text on discard button
@gurjmatharu
chore: fixing css for new & old revision info
fcf7655
@gurjmatharu
refactor: refactoring if statment to switch
52fd67e
@gurjmatharu
test: updating tests
94c86da 
test: updating e2e test

test: updating e2e tests

test: updating test

test: fixing date

test: fixing date rendering

test: fixing date

test: fixing date

chore: fixing accesibility errors

test: updated snapshots

test: fixing accessibility errors
@gurjmatharu
chore: removing todo
6a29b68
@gurjmatharu
style: making arrow smaller
eb20bfa
@gurjmatharu
chore: renaming vars and removing unenecesarry diff
b986bf0
@gurjmatharu
chore: refactoring var names
c522113
@gurjmatharu
refactor: renaming renderData to formatData
e4a0b53
@gurjmatharu
refactor: making names more consistent
3dddec3
@gurjmatharu
refactor: reusing functions
beb8c44
@gurjmatharu
chore: removing unused cases
2cc1307
@gurjmatharu
chore: adding not entered when there is no old data
f70d3cb
@gurjmatharu
test: updating snapshots
e566cb3
@gurjmatharu
test: fixing quarterly report e2e
fe5a911
@gurjmatharu
chore: adding arrow
266d2fc
@gurjmatharu
test: updating css
f5cbf43
@gurjmatharu
refactor: textValue to textData
b3e8563
@gurjmatharu
style: cleanup and removing unused styling
8f14c23
@gurjmatharu
test: updating tests
a796799
@gurjmatharu
chore: added 0 case
ff2c37d
@gurjmatharu
chore: wip
7bd7173
BCerki added 24 commits July 4, 2023 13:11
@BCerki
chore: spec work on adjustable calculated value widget
e252a1f
@BCerki
Revert "chore: spec work on adjustable calculated value widget"
01299d8 
This reverts commit f594363.
@BCerki
test: update jest test post-refactor
30c5edf
@BCerki
chore: update query in quarterly report form
29708cb
@BCerki
chore: fix schema filtering helpers
5661e2e
@BCerki
test: jest test for getSchemaAndDataIncludingCalculatedValues
c895f8f
@BCerki
test: pgtap test handle_emission_intensity_form_change_commit
1cbdd2e
@BCerki
test: pgtap migration
9f9ce2b
@BCerki
chore: migration to reformat old form changes
e481a87
@BCerki
chore: tweak read only adjustable calc value widget
b1f7cc0
@BCerki
test: update schema names in pgtap tests
049a749
@BCerki
chore: update schemas in create_project_revision
6d4cbd0
@BCerki
chore: deprecate add_emission_intensity_report_to_revision
54b77d7
@BCerki
chore: update form_change_as_emission_intensity_report
ae3d1aa
@BCerki
Revert "chore: update form_change_as_emission_intensity_report"
e773be2 
This reverts commit cb56233.
@BCerki
test: update cypress tests
2ac3993
@BCerki
chore: fix duplicate id on summary page
c5c828b
@BCerki
test: pgtap migration
ccf4b27
@BCerki
chore: migration to reformat old form changes
0c71f14
@BCerki
chore: update schemas
5852c7e
@BCerki
chore: apply suggestions from code review
1423f2f
@BCerki
chore: apply suggestions from code review
a431065
@BCerki
chore: apply suggestions from code review
150484d
@BCerki
test: update old pgtap tests with new schema name
98385e5
@BCerki BCerki force-pushed the 1361-refactor-emissions-intensity-schema branch from 799f868 to 98385e5 Compare July 4, 2023 20:18
@BCerki BCerki force-pushed the 1361-refactor-emissions-intensity-schema branch from 3b0b824 to 93018d1 Compare July 4, 2023 21:40
@BCerki BCerki marked this pull request as draft July 6, 2023 15:11
@BCerki
Copy link
Collaborator Author

BCerki commented Jul 6, 2023

Continuing in new PR after hotfix, closing

@BCerki BCerki closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sepehr-Sobhani Sepehr-Sobhani Sepehr-Sobhani requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BCerki @Sepehr-Sobhani @gurjmatharu @dleard @JoshLarouche