1644 login redirect functionality

[JoshLarouche]

zenhub 1644

[Sepehr-Sobhani]

Great Job 👍 Just a couple of changes are required.

[Sepehr-Sobhani]

I think we can do a bit of refactoring on lines 37 through 54, something like:

  let rightSide = isLoggedIn ? (
    <>
      {userProfileComponent}
      <LogoutForm />
    </>
  ) : (
    router.pathname !== "/" && (
      <div
        style={{
          display: "flex",
          flexDirection: "row",
          gap: "1.25em",
        }}
      >
        <LoginForm />
        {showExternalOperatorsLogin && <LoginForm isExternal={true} />}
      </div>
    )
  );

[JoshLarouche]

Good idea! Changed!

[Sepehr-Sobhani]

we can also simplify things here a little bit and have less code to maintain:

      <form id="login-buttons" action={loginURI} method="post">
        <Button
          type="submit"
          variant={
            router.pathname.includes("login-redirect")
              ? "secondary-inverse"
              : isExternal && "secondary"
          }
        >
          {isExternal ? "External User Login" : "Administrator Login"}
        </Button>
      </form>

[JoshLarouche]

Good call! Changed!

[Sepehr-Sobhani]

Also, we need to tweak loginURI too, currently, this part of the AC is not in place:
Then I am redirected back to the page I was trying to get to.
I've played with the code and something like this could be a solution:

  let loginURI = "/login";

  if (router.query.redirectTo)
    loginURI += `?redirectTo=${encodeURIComponent(
      router.query.redirectTo as string
    )}`;
  else if (isExternal)
    loginURI += `?redirectTo=${encodeURIComponent(
      getExternalUserLandingPageRoute().pathname as string
    )}`;

[JoshLarouche]

Good catch I tested mostly with the admin login! Changed!

[Sepehr-Sobhani]

I believe it would be advantageous to conduct a test here on the redirect functionality for external users.

[JoshLarouche]

After discussion with @Sepehr-Sobhani it was determined that it does not make sense to test this for now until we add more external user functionality.