Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculated Fields Tooltips #1747

Closed
wants to merge 100 commits into from
Closed

Calculated Fields Tooltips #1747

wants to merge 100 commits into from

Conversation

sam-warren
Copy link
Contributor

Card: #1692

BCerki and others added 30 commits June 19, 2023 08:35
@BCerki
chore: change text on discard button
3c1b8f4
@Sepehr-Sobhani
Merge pull request #1733 from bcgov/1582-2-preview-revision
4d23aee 
Chore: 1582 change text on discard button
@gurjmatharu
chore: fixing css for new & old revision info
fcf7655
@gurjmatharu
refactor: refactoring if statment to switch
52fd67e
@gurjmatharu
test: updating tests
94c86da 
test: updating e2e test

test: updating e2e tests

test: updating test

test: fixing date

test: fixing date rendering

test: fixing date

test: fixing date

chore: fixing accesibility errors

test: updated snapshots

test: fixing accessibility errors
@gurjmatharu
chore: removing todo
6a29b68
@gurjmatharu
style: making arrow smaller
eb20bfa
@gurjmatharu
chore: renaming vars and removing unenecesarry diff
b986bf0
@gurjmatharu
chore: refactoring var names
c522113
@gurjmatharu
refactor: renaming renderData to formatData
e4a0b53
@gurjmatharu
refactor: making names more consistent
3dddec3
@gurjmatharu
refactor: reusing functions
beb8c44
@gurjmatharu
chore: removing unused cases
2cc1307
@gurjmatharu
chore: adding not entered when there is no old data
f70d3cb
@gurjmatharu
test: updating snapshots
e566cb3
@gurjmatharu
test: fixing quarterly report e2e
fe5a911
@gurjmatharu
chore: adding arrow
266d2fc
@gurjmatharu
test: updating css
f5cbf43
@gurjmatharu
refactor: textValue to textData
b3e8563
@gurjmatharu
style: cleanup and removing unused styling
8f14c23
@gurjmatharu
test: updating tests
a796799
@gurjmatharu
chore: added 0 case
ff2c37d
@gurjmatharu
chore: wip
7bd7173
@gurjmatharu
test: fixing decimal issues
48bc7cc
@gurjmatharu
fix: project forms
e0d9929
@gurjmatharu
fix: ordering of data when we have old, new and latest
566504b
@gurjmatharu
chore: fixing primary contact
63759d8
@gurjmatharu
chore: removing extra param
52fc10e
@gurjmatharu
test: updating e2e
5d03060
@BCerki @gurjmatharu
chore: unicorn
309f1ef
sam-warren and others added 23 commits July 5, 2023 10:38
@sam-warren @BCerki
chore: fix uneven spacing when tooltip contained <ul>
9537d37
@sam-warren @BCerki
chore: add tooltips for Budgets, Expenses & Payments
26862e1
@sam-warren @BCerki
chore: create tooltips for Milestone Reports
9255b03
@sam-warren @BCerki
chore: add tooltips for EI Report
0bf434b
@sam-warren @BCerki
chore: create tooltip test for calculated value widget
9d9679f
@sam-warren @BCerki
chore: update tests to match new default icon
bd27acc
@sam-warren @BCerki
chore: typo fix
bed02bd
@sam-warren @BCerki
chore: remove console log
2325776
@sam-warren @BCerki
chore: implement basic tests
c618db9
@sam-warren @BCerki
chore: add EI report form tests
2ccfd70
@sam-warren @BCerki
chore: clean up EI test, add EI summary tests
fbc210a
@sam-warren @BCerki
chore: create milestone report form tests, update EI tests
091c318
@sam-warren @BCerki
chore: revert changes to EI forms
168df03
@sam-warren @BCerki
chore: create milestone summary tests for tooltips
d8cbc7b
@sam-warren @BCerki
chore: create milestone summary tests for tooltips
56f5394
@sam-warren @BCerki
chore: remove unnecessary function
668222b
@sam-warren @BCerki
feat: move EI tooltips to UI schema
7489507
@sam-warren @BCerki
chore: tooltip typo fix
4351b3e
@sam-warren @BCerki
chore: update spacing, font size, for tooltips
e4d4e15
@sam-warren @BCerki
chore: update tooltip texts to give all bullet points for consistency
d24efda
@sam-warren @BCerki
feat: update milestone form tests for consistency
d9161c1
@sam-warren @BCerki
chore: test for tooltip text in adjustable calculated value widget
304475c
@BCerki
test: jest tests for forms with tooltips
af851a2
@BCerki BCerki force-pushed the chore/calculated-field-tooltips branch from 530f562 to af851a2 Compare July 5, 2023 18:17
@BCerki
Copy link
Collaborator

BCerki commented Jul 5, 2023

Great job 👍 Just a couple of minor changes are required. Also:

  • it would be nice to add an e2e test to check the accessibility of tooltips.
  • We need unit tests for the funding agreement form and its summary page
  • It would be nice to test the text of the tooltips in unit tests and make sure we won't change accidentally later.
  • I think we're covered on the e2e tests already--all the forms have cy.happoAndAxe unless I'm missing something
  • 👍
  • Going to do this via snapshot testing

@BCerki
Copy link
Collaborator

BCerki commented Jul 6, 2023

Found a bug while working on this, https://app.zenhub.com/workspaces/climate-action-secretariat-60ca4121764d710011481ca2/issues/gh/bcgov/cas-cif/1773

@BCerki
Copy link
Collaborator

BCerki commented Jul 6, 2023

Work completed in #1774

@BCerki BCerki closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sepehr-Sobhani Sepehr-Sobhani Sepehr-Sobhani requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sam-warren @Sepehr-Sobhani @BCerki @gurjmatharu @dleard @JoshLarouche