Skip to content

Commit

Permalink
fix: FORMS-1303 rate limit admin, permission, role
Browse files Browse the repository at this point in the history
Applying API rate limiting to the currently non-limited routes in /admin, /permission, and /role.
  • Loading branch information
WalterMoar committed Sep 26, 2024
1 parent 67d7aae commit 94a5dfd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions app/src/forms/admin/routes.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@ const routes = require('express').Router();

const jwtService = require('../../components/jwtService');
const currentUser = require('../auth/middleware/userAccess').currentUser;
const rateLimiter = require('../common/middleware').apiKeyRateLimiter;
const validateParameter = require('../common/middleware/validateParameter');
const userController = require('../user/controller');
const controller = require('./controller');

routes.use(rateLimiter);

// Routes under /admin fetch data without doing form permission checks. All
// routes in this file should remain under the "admin" role check, with the
// "admin" role only given to people who have permission to read all data.
Expand Down
2 changes: 2 additions & 0 deletions app/src/forms/permission/routes.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ const routes = require('express').Router();

const jwtService = require('../../components/jwtService');
const currentUser = require('../auth/middleware/userAccess').currentUser;
const rateLimiter = require('../common/middleware').apiKeyRateLimiter;
const validateParameter = require('../common/middleware/validateParameter');
const controller = require('./controller');

routes.use(rateLimiter);
routes.use(jwtService.protect('admin'));
routes.use(currentUser);

Expand Down
2 changes: 2 additions & 0 deletions app/src/forms/role/routes.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ const routes = require('express').Router();

const jwtService = require('../../components/jwtService');
const currentUser = require('../auth/middleware/userAccess').currentUser;
const rateLimiter = require('../common/middleware').apiKeyRateLimiter;
const validateParameter = require('../common/middleware/validateParameter');
const controller = require('./controller');

routes.use(rateLimiter);
routes.use(currentUser);

routes.param('code', validateParameter.validateRoleCode);
Expand Down

0 comments on commit 94a5dfd

Please sign in to comment.