-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openshift v4 migration #1696
Openshift v4 migration #1696
Conversation
@kuanfandevops When a pull request (PR) is over the 200-400 line range (of change) the ability of the reviewer to effectively detect issues quickly diminishes. Your PR is over the preferred length of 1000 lines set for this repo. While this cannot always be avoided, please be mindful of the reviewer's time by organizing your work into smaller, more manageable PRs. Here are a few thoughtful articles on what a good PR should look like: The Anatomy of a Perfect Pull Request Best Practices for Code Review Pro Tip
|
No description provided.