Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should commit or disable lockfile #128

Closed
wants to merge 1 commit into from
Closed

We should commit or disable lockfile #128

wants to merge 1 commit into from

Conversation

voxpelli
Copy link
Collaborator

I'm on the side of disabling it

@voxpelli voxpelli requested a review from bcomnes January 14, 2024 15:50
@voxpelli voxpelli self-assigned this Jan 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (79e2c97) 96.82% compared to head (75de9af) 96.31%.
Report is 16 commits behind head on master.

Files Patch % Lines
lib/run-task.js 84.81% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   96.82%   96.31%   -0.52%     
==========================================
  Files          35       35              
  Lines        2080     2114      +34     
==========================================
+ Hits         2014     2036      +22     
- Misses         66       78      +12     
Flag Coverage Δ
macos-latest-18 96.22% <84.81%> (-0.53%) ⬇️
ubuntu-latest-18 95.83% <84.81%> (-0.53%) ⬇️
windows-latest-18 95.85% <84.81%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bcomnes
Copy link
Owner

bcomnes commented Jan 14, 2024

Package.lock is ignored in .gitignore already. Is this something you can set in your global .npmrc or a local one that is also gitignored in this repo? It's not set up here yet, but I like lock files generated in CI and uploaded as a run artifact that way I can back out the same dependency set locally as a failed run if needed.

@voxpelli
Copy link
Collaborator Author

Right, I'm okay with that :)

@voxpelli voxpelli closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants