Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern match on the object key in a stripe response to convert to proper module #189

Closed
begedin opened this issue Jan 15, 2017 · 2 comments

Comments

@begedin
Copy link
Contributor

begedin commented Jan 15, 2017

From #187, if we similarly pattern match on the root object key, we should be able to eliminate the need to send a module as a parameter to Converter.stripe_map_to_struct. If we look into it, it might even be possible to eliminate this need from the various Request.<action> methods.

Copy link

This issue has been automatically marked as "stale:discard". If this issue still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment.

Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still relevant, feel free to re-open the issue. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant