Pattern match on object keys for response sub-objects #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsmith
reviewed
Jan 15, 2017
| assert object_name_to_module("plan") == Stripe.Plan | ||
| assert object_name_to_module("subscription") == Stripe.Subscription | ||
| assert object_name_to_module("token") == Stripe.Token | ||
| end |
There was a problem hiding this comment.
Spacing is a tad off here.
begedin
force-pushed
the
186-pattern-match-on-object-keys
branch
from
0e22b8a
to
7b0ac4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the converter module to pattern match on object keys for sub-hashes, if these are present. It allows us to properly serialize stripe objects such as events, due to these having dynamic relationships (an event can hold any other non-specific stripe object).
It also completely removes the need for the relationships attribute/method on all our modules.
Closes #187
This change puts us in a position where we could similarly do the same for the base object itself, since all Stripe objects have the "object" key. It would remove the need to pass in the module into our
Converter.stripe_map_to_structmethod. It potentially even could allow us to remove the need to pass in the module into ourRequest.<action>methods.Another option this opens is the ability to properly serialize lists. I will create issues for both of these.