Add Stripe.Account #116
Merged
Add Stripe.Account #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
| end | ||
|
|
||
| defp to_struct(response) do |
There was a problem hiding this comment.
You may not want this to be private, but I doubt other modules will have accounts as sub-data structures
There was a problem hiding this comment.
Yeah, we'll stay private for now, but good point for the future.
| alias Stripe.Util | ||
|
|
||
| @type id :: String.t | ||
| @type id_or_opts :: String.t | Keyword.t |
There was a problem hiding this comment.
Where is this used?
|
|
||
| alias Stripe.Util | ||
|
|
||
| @type id :: String.t |
There was a problem hiding this comment.
I don't see this used currently
|
Just a few comments, everything else looks good 👍 |
Fix usage of lists for hackney opts Add retrieving your own account
joshsmith
force-pushed
the
108-add-stripe-account
branch
from
84f4997
to
cabec08
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #108 when done.