Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deleting subscriptions with options #16

Merged
merged 2 commits into from
Dec 20, 2015

Conversation

williamhogman
Copy link
Contributor

Useful for ending subscriptions on the next billing date, see https://stripe.com/docs/api#cancel_subscription

@williamhogman
Copy link
Contributor Author

Thanks for the quick response :)

Yes, it encapsulated the incorrect assumption that DELETE methods cannot have request bodies. If a delete request did have a body it would be silently ignored and not passed on to HTTPPoison, which made my code really hard to debug. I think it is more sensible to let the upstream library figure out what is correct HTTP and for us to put a thin wrapper around it managing authentication.

@robconery
Copy link
Contributor

Ahhh - that would make sense and yeah, I didn't catch that last part :) thanks!

robconery added a commit that referenced this pull request Dec 20, 2015
Allow deleting subscriptions with options
@robconery robconery merged commit 2dd6da0 into beam-community:master Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants