Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parameter order for Stripe.request and updated all calls. #211

Merged
merged 2 commits into from
Feb 12, 2017

Conversation

asummers
Copy link
Contributor

@asummers asummers commented Feb 9, 2017

This allows pipelining the request body through as the first argument of Stripe.request, resulting in a cleaner request module, when used in combination in combination with handle_result.

@begedin
Copy link
Contributor

begedin commented Feb 11, 2017

@asummers Merging #197 created some conflicts. Hopefully, however, this will make the changes even simpler. Once you resolve I'll have another look and we can merge.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 26.977% when pulling e6718d9 on asummers:change-arg-order-request into ad063a4 on code-corps:2.0.

@begedin
Copy link
Contributor

begedin commented Feb 12, 2017

This looks good. As soon as you squash, this is good to merge.

@asummers asummers merged commit b5f6bc6 into beam-community:2.0 Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants