Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters to DELETE requests (#222) #223

Merged
merged 1 commit into from
May 1, 2017
Merged

Add parameters to DELETE requests (#222) #223

merged 1 commit into from
May 1, 2017

Conversation

jayjun
Copy link
Contributor

@jayjun jayjun commented Mar 16, 2017

Support passing parameters to DELETE requests, e.g. at_period_end=true when cancelling a subscription.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 21.287% when pulling 1af8597 on jayjun:2.0 into 1e9b87d on code-corps:2.0.

@joshsmith joshsmith requested a review from begedin March 16, 2017 08:18
@jayjun
Copy link
Contributor Author

jayjun commented May 1, 2017

@joshsmith @begedin Hi guys, just bumping this. Wonder why it hasn't been merged.

Copy link
Contributor

@begedin begedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the late review. The way see it, this adds functionality and does not break anything. In my opinion, it's good to merge. If there's ever a need to write it differently, it's not clear now, so we can deal if/when that happens.

@begedin begedin merged commit 1a76885 into beam-community:2.0 May 1, 2017
@jayjun
Copy link
Contributor Author

jayjun commented May 10, 2017

@begedin Sorry for bringing up a closed issue, but how often are 2.0 updates released to Hex? I was hoping my pull request would make it into 2.0.0-alpha.7 or something.

@begedin
Copy link
Contributor

begedin commented May 11, 2017

@jayjun I don't have the credentials, but I'll see about someone releasing a new version asap.

joshsmith pushed a commit that referenced this pull request May 15, 2017
Add parameters to DELETE requests (#222)
@begedin
Copy link
Contributor

begedin commented May 15, 2017

@jayun The new version has been published now

@joshsmith
Copy link
Contributor

Sorry @jayjun for the late publish to Hex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants