Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport webhooks support #244

Merged
merged 1 commit into from
Jul 4, 2017
Merged

Backport webhooks support #244

merged 1 commit into from
Jul 4, 2017

Conversation

jayjun
Copy link
Contributor

@jayjun jayjun commented Jul 4, 2017

Backport support for validating webhook signatures to 1.x (see #239).

@coveralls
Copy link

coveralls commented Jul 4, 2017

Coverage Status

Coverage increased (+1.2%) to 79.553% when pulling a24a7c1 on jayjun:webhooks into 1b6a71a on code-corps:master.

Copy link
Contributor

@begedin begedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as with #239, just a minor change needed and I can merge this ASAP.

{:error, reason} ->
# Reject webhook by responding with non-2XX
end
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike my comment in #239, the master branch does not have a %Stripe.Event{}, so the only thing to do here is to update the comments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, comments fixed.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 79.553% when pulling 5092ef8 on jayjun:webhooks into 1b6a71a on code-corps:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 79.553% when pulling 5092ef8 on jayjun:webhooks into 1b6a71a on code-corps:master.

@begedin begedin merged commit 4fe2112 into beam-community:master Jul 4, 2017
@lessless
Copy link

lessless commented Jul 4, 2017

Thanks, guys! Awesome job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants