Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Token, BankAccount, Card, Source types #273

Merged
merged 4 commits into from
Nov 18, 2017

Conversation

joshsmith
Copy link
Contributor

@joshsmith joshsmith commented Nov 18, 2017

Note that this adds a token_bank_account and token_card as the OpenAPI specs for Stripe indicate that these have different schemas from our own Stripe.BankAccount and Stripe.Card.

I've also now added Stripe.Types.metadata so we can stop repeating that key.

Also moved some of the types like account_holder_type, status, tokenization_method, etc. into the relevant entities such as Stripe.BankAccount.status.

This also expands on the Source types and their inner structure.

@joshsmith joshsmith changed the title Clean up Token types Clean up Token, BankAccount, Card, Source types Nov 18, 2017
@beam-community beam-community deleted a comment from coveralls Nov 18, 2017
@beam-community beam-community deleted a comment from coveralls Nov 18, 2017
@beam-community beam-community deleted a comment from coveralls Nov 18, 2017
@coveralls
Copy link

coveralls commented Nov 18, 2017

Coverage Status

Coverage remained the same at 55.587% when pulling 8d9a78c on clean-up-token-types into c803f92 on 2.0-beta.

@joshsmith joshsmith merged commit 3cc9dd7 into 2.0-beta Nov 18, 2017
@joshsmith joshsmith deleted the clean-up-token-types branch November 18, 2017 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants