Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ExternalAccount endpoints #327

Merged
merged 1 commit into from
Nov 25, 2017
Merged

Add ExternalAccount endpoints #327

merged 1 commit into from
Nov 25, 2017

Conversation

joshsmith
Copy link
Contributor

  • Removes the ability to send hashes for external accounts, taking inspiration from the Go library while still allowing this module to be used, e.g. in Go: bankaccount.New(&stripe.BankAccountParams{AccountID: {ACCOUNT_ID}, Token: {TOKEN_ID}})
  • Supports list with a required atom

@joshsmith joshsmith force-pushed the add-external-account-endpoints branch 2 times, most recently from 0519bdd to 7d5b9e0 Compare November 25, 2017 20:08
@coveralls
Copy link

coveralls commented Nov 25, 2017 •
edited
Loading

Coverage Status

Coverage increased (+3.9%) to 79.058% when pulling 0519bdd on add-external-account-endpoints into 457f6b6 on 2.0-beta.

@joshsmith joshsmith force-pushed the add-external-account-endpoints branch from 7d5b9e0 to ffb0791 Compare November 25, 2017 20:10
@coveralls
Copy link

coveralls commented Nov 25, 2017 •
edited
Loading

Coverage Status

Coverage increased (+3.9%) to 79.058% when pulling ffb0791 on add-external-account-endpoints into 457f6b6 on 2.0-beta.

@joshsmith joshsmith merged commit c1740a7 into 2.0-beta Nov 25, 2017
@joshsmith joshsmith deleted the add-external-account-endpoints branch November 25, 2017 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asummers asummers asummers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshsmith @coveralls @asummers