Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add payment intents #470

Merged
merged 3 commits into from
Mar 19, 2019
Merged

add payment intents #470

merged 3 commits into from
Mar 19, 2019

Conversation

christian-froh
Copy link
Contributor

@christian-froh christian-froh commented Mar 8, 2019 •
edited
Loading

@snewcomer Sry I had to close old the PR, something got messed up.
I've added the test.

@christian-froh christian-froh mentioned this pull request Mar 8, 2019
Closed
@coveralls
Copy link

coveralls commented Mar 8, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 85.185% when pulling 251533b on christian-froh:feature/payment_intents into 13f8f3e on code-corps:master.

dnsbty
dnsbty reviewed Mar 13, 2019
View reviewed changes
Copy link
Contributor

@dnsbty dnsbty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just about to submit a PR for this, but I'm happy to see that someone else took it on!

The one thing I would add (other than the change I marked) is the payment_intent field on the Stripe.Charge type and struct. Other than that I think it looks great!

@christian-froh
Copy link
Contributor Author

Thanks for your help @dnsbty. I added the payment_intent to the charge object

snewcomer
snewcomer reviewed Mar 19, 2019
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more cleanup items, but otherwise great work!

lib/stripe/core_resources/charge.ex Show resolved Hide resolved
lib/stripe/core_resources/payment_intent.ex Outdated Show resolved Hide resolved
lib/stripe/core_resources/payment_intent.ex Outdated Show resolved Hide resolved
lib/stripe/core_resources/payment_intent.ex Outdated Show resolved Hide resolved
lib/stripe/core_resources/payment_intent.ex Show resolved Hide resolved
@christian-froh
Copy link
Contributor Author

A few more cleanup items, but otherwise great work!

done!

snewcomer
snewcomer approved these changes Mar 19, 2019
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🎬

@snewcomer snewcomer merged commit b60b357 into beam-community:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsbty dnsbty dnsbty left review comments

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christian-froh @coveralls @dnsbty @snewcomer