-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate struct keys #575
Remove duplicate struct keys #575
Conversation
collection_method is specified twice in the typespecs and struct definition, leading to a compile-time warning: warning: duplicate key :collection_method found in struct (elixir 1.10.0) lib/kernel/utils.ex:119: Kernel.Utils.warn_on_duplicate_struct_key/1 (elixir 1.10.0) lib/kernel/utils.ex:98: Kernel.Utils.defstruct/2 lib/stripe/subscriptions/subscription.ex:56: (module) (elixir 1.10.0) src/elixir_compiler.erl:75: :elixir_compiler.dispatch/4 (elixir 1.10.0) src/elixir_compiler.erl:60: :elixir_compiler.compile/3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it duped in the structs? I only see two dups in this file - https://github.com/code-corps/stripity_stripe/blob/ffe1d9fedd463417e2ac25543137f54cd02c490c/lib/stripe/subscriptions/subscription.ex#L106
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
collection_method is specified twice in the typespecs and struct definition for
subscriptions/invoice
andsubscriptions/subscription
, leading to a compile-time warning: