changed params for subscription to accept default payment method #592
Conversation
| @@ -124,7 +124,7 @@ defmodule Stripe.Subscription do | |||
| optional(:trial_from_plan) => boolean, | |||
| optional(:trial_period_days) => non_neg_integer | |||
| } | |||
| def create(%{customer: _, items: _} = params, opts \\ []) do | |||
There was a problem hiding this comment.
THis ensures that the create action is passed with a customer and items.
There was a problem hiding this comment.
Do you think we need this? It seems these two are required.
There was a problem hiding this comment.
Oh sorry, I think it's necessary to provide it for the sake of keeping in line with the tutorial. If we'd like to figure out if the user has passed in a customer and items key, we can probably just use the Map.has_key?(params, :customer) and if it returns false, we throw an exception.
| @@ -164,6 +164,7 @@ defmodule Stripe.Subscription do | |||
| optional(:items) => [ | |||
| %{ | |||
| :plan => Stripe.id() | Stripe.Plan.t(), | |||
| optional(:id) => Stripe.id() | binary(), | |||
There was a problem hiding this comment.
Is this documented anywhere?
There was a problem hiding this comment.
It's located here as an optional parameter
It's also considered a required parameter when upgrading and downgrading a user subscription
When updating a new subscription, it's considered to be an optional parameter. When I was attempting to upgrade and downgrade my current subscription, I realized this library doesn't allow for me to upgrade/downgrade an existing subscription.
Made a minor change to the api that allows you to pass a default payment method directly into the parameters of Stripe.Subscription.create.