Add promotion_code to Discount #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Looks like travis passed. Github or some other service might have had downtime. Thank you for your contribution. We'll merge as soon as we get another review. |
begedin
approved these changes
Dec 11, 2020
|
Ah there we go. We should probably migrate to Github Actions or something similar. Lmk if you have any recommendations! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I need the
promotion_codereturned from Stripe objects (Subscription, Invoice, ect...) for a project I am working on and it gets removed from the payload since it is not defined in the Discount module. Adding this fixes my issue.PS: Travis fails, however all the tests pass... Not sure what that is about, if it is something on my end please let me know but I have looked and could not figure it out. It complains and exits on something to do with
mix coveralls.travis