Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customer field to PromotionCode #676

Merged
merged 2 commits into from Aug 23, 2021
Merged

Add customer field to PromotionCode #676

merged 2 commits into from Aug 23, 2021

Conversation

sezaru
Copy link

@sezaru sezaru commented Jun 19, 2021

No description provided.

@sezaru
Copy link
Author

sezaru commented Jun 19, 2021

Customer field is missing in PromotionCode struct.

For some reason, after this change I'm getting this error:

== Compilation error in file lib/core/stripe/promotion_code.ex ==
** (ArgumentError) errors were found at the given arguments:

  * 1st argument: the table identifier does not refer to an existing ETS table

    (stdlib 3.15) :ets.lookup_element(:hackney_config, :mod_metrics, 2)
    (hackney 1.17.4) /home/sezdocs/projects/tip-off/alarms_backend/payments/deps/hackney/src/hackney_metrics.erl:27: :hackney_metrics.get_engine/0
    (hackney 1.17.4) /home/sezdocs/projects/tip-off/alarms_backend/payments/deps/hackney/src/hackney_connect.erl:75: :hackney_connect.create_connection/5
    (hackney 1.17.4) /home/sezdocs/projects/tip-off/alarms_backend/payments/deps/hackney/src/hackney_connect.erl:44: :hackney_connect.connect/5
    (hackney 1.17.4) /home/sezdocs/projects/tip-off/alarms_backend/payments/deps/hackney/src/hackney.erl:335: :hackney.request/5
    (stripity_stripe 2.10.0) lib/stripe/api.ex:380: Stripe.API.do_perform_request_and_retry/6
    (stripity_stripe 2.10.0) lib/stripe/request.ex:198: Stripe.Request.make_request/1
    lib/core/stripe/promotion_code.ex:9: Core.Stripe.PromotionCode.maybe_get/2
    lib/core/stripe/promotion_code.ex:33: (file)
    (elixir 1.12.0) lib/kernel/parallel_compiler.ex:319: anonymous fn/4 in Kernel.ParallelCompiler.spawn_workers/7

But using the commit in the 2.10.0 tag works here.. Not sure if this is something to do with my change or with something broken in the master branch

@snewcomer
Copy link
Collaborator

@sezaru Mind brining in the master branch and see if we still get an error?

@sezaru
Copy link
Author

sezaru commented Aug 23, 2021

@snewcomer just tested it, I was able to compile the whole project now without any issues.

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Great job here

@snewcomer snewcomer merged commit bc70275 into beam-community:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants