Merge PR #514 into 12.0

Signed-off-by huguesdk

shift/models/cooperative_status.py

@@ -191,8 +191,11 @@ def _compute_status(self):
 
     @api.constrains("working_mode", "irregular_start_date")
     def _constrains_irregular_start_date(self):
-        if self.working_mode == "irregular" and not self.irregular_start_date:
-            raise UserError(_("Irregular workers must have an irregular start date."))
+        for status in self:
+            if status.working_mode == "irregular" and not status.irregular_start_date:
+                raise UserError(
+                    _("Irregular workers must have an irregular start date.")
+                )
 
     def _get_watched_fields(self):
         """

shift/newsfragments/514.bugfix.rst

@@ -0,0 +1,3 @@
+Fixed a bug where writing to multiple cooperative.status records simultaneously
+caused a singleton error. Writing to multiple records simultaneously is now
+possible.

shift/tests/test_shift.py

@@ -505,3 +505,12 @@ def test_unsubscribe_worker_from_task_template_computes_next_shift(self):
             self.worker_regular_1.cooperative_status_ids.next_shift_id,
             next_shift,
         )
+
+    def test_write_multiple_statuses(self):
+        """A naïve test that verifies that the write function on multiple status
+        records doesn't result in an error.
+        """
+        statuses = self.env["cooperative.status"]
+        statuses |= self.worker_regular_1.cooperative_status_ids
+        statuses |= self.worker_irregular_2.cooperative_status_ids
+        statuses.write({"irregular_start_date": "2023-05-08"})