Skip to content

Commit

Permalink
Ensure csharpier formatting happens before compiling so that breakpoi…
Browse files Browse the repository at this point in the history 
…nts work properly (#675)

closes #674
  • Loading branch information
@belav
belav committed May 23, 2022
1 parent 0e833f8 commit 15061de
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Src/CSharpier.MsBuild/build/CSharpier.MsBuild.targets
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<!-- Target invokes the copy of csharpier from this package on the current project -->
<Target
Name="CSharpierFormat"
BeforeTargets="Build">
BeforeTargets="CoreCompile">

This comment has been minimized.

Sign in to view

Copy link
@shocklateboy92

shocklateboy92 Sep 3, 2023

Collaborator

So, it turns out doing this broke error output:
image

Since CSharpier now runs before compilation, when a unit fails to compile, the regular compilation target is not run.
This means the error messages that IDEs (including VSCode) can pick up are not emitted.

This comment has been minimized.

Sign in to view

Copy link
@belav

belav Sep 8, 2023

Author Owner

I created #957 to address this
<Exec Command="dotnet $(CSharpierDllPath) $(CSharpierArgs) $(MSBuildProjectDirectory)" />
</Target>
</Project>

0 comments on commit 15061de

Please sign in to comment.