Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom extensions in .editorconfig #1273

Closed
belav opened this issue May 31, 2024 · 3 comments · Fixed by #1346
Closed

Support custom extensions in .editorconfig #1273

belav opened this issue May 31, 2024 · 3 comments · Fixed by #1346
Milestone

Comments

@belav
Copy link
Owner

belav commented May 31, 2024

#1251 is adding the ability to customize options based on file path, which will also allow non-standard file extensions to be formatted.

This issue is for adding support for this to .editorconfig

@belav belav modified the milestones: 0.29.0, Planned, 0.29.1 May 31, 2024
@belav belav modified the milestones: 0.29.1, 0.29.2 Aug 23, 2024
@viceice
Copy link

viceice commented Sep 4, 2024

Would this also enable setting preprocessorSymbolSets via .editorconfig? That option force me to use .csharpierrc for configuration.

@belav
Copy link
Owner Author

belav commented Sep 4, 2024

Would this also enable setting preprocessorSymbolSets via .editorconfig? That option force me to use .csharpierrc for configuration.

@viceice preprocessorSymbolSets hasn't been supported as an option for a few versions now. CSharpier can parse the conditions in the preprocessor directives and build its own sets for each file.

@viceice
Copy link

viceice commented Sep 5, 2024

Would this also enable setting preprocessorSymbolSets via .editorconfig? That option force me to use .csharpierrc for configuration.

@viceice preprocessorSymbolSets hasn't been supported as an option for a few versions now. CSharpier can parse the conditions in the preprocessor directives and build its own sets for each file.

oh, I missed that change 😅. so I'll drop the explicit config in favor of editor config. 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants