Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File with no preprocessor symbols formats twice. #555

Closed
belav opened this issue Jan 20, 2022 · 0 comments · Fixed by #560
Closed

File with no preprocessor symbols formats twice. #555

belav opened this issue Jan 20, 2022 · 0 comments · Fixed by #560
Labels
area:formatting priority:medium type:bug Something isn't working
Milestone
0.14.0

Comments

@belav
Copy link
Owner

belav commented Jan 20, 2022

See CodeFormatter line 122 or so, if that returns an empty array, we should not format again.
Or it should not return anything if there are no symbol sets.
belav added a commit that referenced this issue Jan 20, 2022
@belav
Don't format a document with no preprocessor symbols twice.
0820c17 
closes #555
@belav belav mentioned this issue Jan 20, 2022
Merged
@belav belav added this to the 0.14.0 milestone Jan 20, 2022
belav added a commit that referenced this issue Jan 22, 2022
@belav
If file has no preprocessor symbols, only format it once (#560)
934b85a 
* Don't format a document with no preprocessor symbols twice.

closes #555

* Fixing edge case that showed up after we no longer format a file twice in a row
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:formatting priority:medium type:bug Something isn't working
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

If file has no preprocessor symbols, only format it once belav/csharpier
1 participant
@belav