Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional access edge cases #603

Closed
belav opened this issue Feb 8, 2022 · 1 comment · Fixed by #640
Closed

Conditional access edge cases #603

belav opened this issue Feb 8, 2022 · 1 comment · Fixed by #640
Milestone

Comments

@belav
Copy link
Owner

belav commented Feb 8, 2022

These may be related to the way #596 edge cases are handled

// these do not format consistently if you remove the ?

            output.Measurements.Add(
                new BenchmarkMeasurement
                {
                    Timestamp = DateTime.UtcNow,
                    Name = "blazorwasm/commit",
                    Value = typeof(Program).Assembly
                        .GetCustomAttributes<AssemblyMetadataAttribute>()
                        .FirstOrDefault(f => f.Key == "CommitHash")?.Value,
                }
            );

                    var runtimeVersion =
                        typeof(object).Assembly
                            .GetCustomAttribute<AssemblyInformationalVersionAttribute>()
                            ?.InformationalVersion ?? "Unknown";

        return httpContext.RequestServices
                ?.GetService<IOptions<JsonOptions>>()
                ?.Value?.SerializerOptions ?? JsonOptions.DefaultSerializerOptions;

var ignoredSourceMembers = _sourceMemberConfigs?
                    .Values.Where(smc => smc.IsIgnored())
                    .Select(pm => pm.SourceMember.Name);
@belav belav added this to the 0.16.0 milestone Feb 8, 2022
@belav belav added area:formatting type:bug Something isn't working labels Feb 8, 2022
@belav belav removed this from the 0.16.0 milestone Feb 8, 2022
@belav belav added this to the 0.16.0 milestone Mar 7, 2022
@belav
Copy link
Owner Author

belav commented Mar 7, 2022

The only edgecase left is this one

        var x = typeof(Program).Assembly
            .GetCustomAttributes<AssemblyMetadataAttribute>()
            .FirstOrDefault(f => f.Key == "CommitHash")
            ?.Value;

// should be formatted like above, without the ?
        var x =
            typeof(Program).Assembly
                .GetCustomAttributes<AssemblyMetadataAttribute>()
                .FirstOrDefault(f => f.Key == "CommitHash")
                .Value;

@belav belav modified the milestones: 0.16.0, 0.17.0 Mar 26, 2022
belav added a commit that referenced this issue Apr 4, 2022
shocklateboy92 added a commit that referenced this issue Apr 7, 2022
closes #603

Co-authored-by: Lasath Fernando <devel@lasath.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant