Allowing new lines in object initializers #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Src/SyntaxFinder/Program.cs
Outdated
| } | ||
| } | ||
| var files = Directory.EnumerateFiles( | ||
| "C:\\projects\\csharpier-repos", |
There was a problem hiding this comment.
Uhm... could you add a readme file explaining that this is tool for finding test cases in csharpier-repos?
Maybe a sentence or two explaining how to use it (either here, or in the contributing/development doc) along with maybe a link to the repo?
There was a problem hiding this comment.
Actually, you want to split that out into a separate PR?
This will make no sense for anyone looking at the history at a later date.
There was a problem hiding this comment.
Makes sense to me, and I figured out a cleaner way to split a PR just now, at least when the changes are all in different files.
Cherry pick to new branch without commiting, only stage the files you want then commit, force push over current branch.
belav
force-pushed
the
allow-lines-in-initializers
branch
from
c6fdd81
to
e8f69c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1110