Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite CSharpier_Check, when already set. #1314

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

PetSerAl
Copy link
Contributor

@PetSerAl PetSerAl commented Aug 6, 2024

At this point CSharpier_Check can be already set. For example: Directory.Build.props imported before CSharpier.MsBuild.props, and CSharpier_Check can be set here. Set default value only when current is empty.

Copy link
Collaborator

@shocklateboy92 shocklateboy92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@shocklateboy92 shocklateboy92 merged commit 29f9db4 into belav:main Aug 6, 2024
3 checks passed
@belav belav added this to the 0.29.0 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants