fixing some more edge cases with leading comments affecting breaking #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shocklateboy92
approved these changes
May 25, 2021
| @@ -25,4 +25,18 @@ class ClassName | |||
| "ifThisIsReallyLongItShouldntInsertAnExtraLineAboveItttttttttttttttt" | |||
| } | |||
| }; | |||
|
|
|||
| private SomeClass[,] someClass = { | |||
There was a problem hiding this comment.
Is this valid synatx? what does it even do? 🤔
There was a problem hiding this comment.
It's a 2 dimensional array of SomeClass without the size specified. It doesn't really need to be SomeClass after thinking about it. I ran into it in the runtime or roslyn repo and wasn't really sure what it did at first either.
| } | ||
| if ( | ||
| line.Type == LineDoc.LineType.Hard | ||
| && currentDoc |
There was a problem hiding this comment.
wouldn't it make more sense to do an else if here, instead of having the inverse condition as an &&?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #217