Merge pull request #61 from benbalter/cliver

Use cliver to detect pa11y

lib/site-inspector.rb

@@ -2,6 +2,7 @@
 require 'addressable/uri'
 require 'public_suffix'
 require 'typhoeus'
+require 'cliver'
 require 'cgi'
 
 require_relative 'site-inspector/cache'

lib/site-inspector/checks/accessibility.rb

@@ -22,7 +22,7 @@ def pa11y_version
         end
 
         def pa11y?
-          !pa11y_version.nil?
+          !!(Cliver.detect('pa11y'))
         end
         alias_method :enabled?, :pa11y?
       end
@@ -83,7 +83,7 @@ def respond_to?(method_sym, include_private = false)
       private
 
       def pa11y(standard)
-        raise "pa11y not found. To install: [sudo] npm install -g pa11y" unless self.class.pa11y?
+        Cliver.assert('pa11y')
         raise ArgumentError, "Unknown standard '#{standard}'" unless standard?(standard)
 
         args = [

site-inspector.gemspec

@@ -25,6 +25,7 @@ Gem::Specification.new do |s|
   s.add_dependency("oj", "~> 2.11")
   s.add_dependency("mercenary", "~> 0.3")
   s.add_dependency("colorator", "~> 0.1")
+  s.add_dependency("cliver", "~> 0.3")
   s.add_development_dependency("pry", "~> 0.10")
   s.add_development_dependency( "rake", "~> 10.4" )
   s.add_development_dependency( "rspec", "~> 3.2")

spec/checks/site_inspector_endpoint_accessibility_spec.rb

@@ -78,18 +78,4 @@
       expect(subject.check[:results].first["code"]).to eql("Section508.L.NoContentAnchor")
     end
   end
-
-  context "without pa11y installed" do
-    before do
-      allow(subject.class).to receive(:pa11y_version) { nil }
-    end
-
-    it "knows when pa11y insn't installed" do
-      expect(subject.class.pa11y?).to eql(false)
-    end
-
-    it "fails loudly withouy pa11y" do
-      expect{subject.check}.to raise_error("pa11y not found. To install: [sudo] npm install -g pa11y")
-    end
-  end
 end