Fix relative statistics calculations #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to rely on the inputs being there and then working based off on them - too bad, if we use `Benchee.load` then there are no inputs to go off, but they are still in the scenarios to work with them. Needs some care to preserve order which looks odd but couldn't find a better way.
PragTob
force-pushed
the
fix-relative-statistics
branch
from
77e5db2
to
02ab998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to rely on the inputs being there and then working based off on them - too bad, if we use
Benchee.loadthen there are no inputs to go off, but they are still in the scenarios to work with them. Needs some care to preserve order which looks odd but couldn't find a better way.