Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce known issues and point people to it #407

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Introduce known issues and point people to it #407

merged 4 commits into from
Dec 14, 2023

Conversation

PragTob
Copy link
Member

@PragTob PragTob commented Dec 13, 2023

@PragTob
Copy link
Member Author

PragTob commented Dec 13, 2023

@sabiwara if you wanted to give this a quick review, I'd appreciate it :)

@PragTob PragTob mentioned this pull request Dec 13, 2023
Closed
sabiwara
sabiwara approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@sabiwara sabiwara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's perfect! 💯
I just left a couple nit suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@PragTob @sabiwara
Splendid improvements from @sabiwara
2303f22 
Co-authored-by: Jean Klingler <sabiwara@gmail.com>
@PragTob
Copy link
Member Author

PragTob commented Dec 14, 2023

@sabiwara thanks a ton for the suggestions and the time!

IMG_20220901_174517

@PragTob
Copy link
Member Author

PragTob commented Dec 14, 2023

Aight after some further testing I had found some unaffected examples, which makes sense as only some optimizations were disabled. Tried to clarify that in text. Merging after this, we can always iterate/fix later on :)

@PragTob PragTob merged commit cae111d into main Dec 14, 2023
44 checks passed
@PragTob PragTob deleted the add-known-issues-section branch December 14, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabiwara sabiwara sabiwara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Top level functions slower than module functions in Elixir <1.16
2 participants
@PragTob @sabiwara