Reset _stream_ready after exception in _make_connection.
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reset `_stream_ready` Event after an exception in `_make_connection`. This allows for subsequent blind control to succeed after a network failure. Otherwise (as it stands today), all future attempts to control a blind result in an infinite wait in _make_connection#79 on `await self._stream_ready.wait().`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider this PR. I am experiencing this issue when running homeassistant. I'm not sure why my myLink is having intermittent connectivity issues (maybe I am exacerbating it with my automation frequency). This PR fixes HA losing control of the blinds once encountering an error (ie, subsequent attempts to control the blind can often succeed).