Merge pull request #692 from AntoineAugusti/redirect-308

Follow HTTP 308 redirects
benoitc · Mar 14, 2023 · 0017d77 · 0017d77
2 parents 6cfebbe + 2045c64
commit 0017d77
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/hackney.erl b/src/hackney.erl
@@ -725,7 +725,7 @@ maybe_redirect(
   case redirect_location(Headers) of
     undefined -> Resp;
     Location ->
-      IsRedirect = lists:member(S, [301, 302, 303, 307]),
+      IsRedirect = lists:member(S, [301, 302, 303, 307, 308]),
       case IsRedirect of
         false -> Resp;
         _ ->
@@ -734,7 +734,7 @@ maybe_redirect(
       end
   end;
 maybe_redirect({ok, S, _H, #client{follow_redirect=true}}=Resp, _Req) ->
-  case lists:member(S, [301, 302, 303, 307]) of
+  case lists:member(S, [301, 302, 303, 307, 308]) of
     true ->
       {error, {max_redirect_overflow, Resp}};
     false ->
@@ -746,7 +746,7 @@ maybe_redirect(Resp, _Req) ->
 
 maybe_redirect1(Location, {ok, S, H, #client{retries=Tries}=Client}=Resp, Req) ->
   {Method, _Path, Headers, Body} = Req,
-  case lists:member(S, [301, 302, 307]) of
+  case lists:member(S, [301, 302, 307, 308]) of
     true  ->
       ?report_debug("redirect request", [{location, Location},
                                          {req, Req},

diff --git a/src/hackney_stream.erl b/src/hackney_stream.erl
@@ -170,7 +170,7 @@ maybe_redirect(Parent, Owner, Ref, StatusInt, Reason,
                        socket=Socket,
                        method=Method,
                        follow_redirect=true}=Client) ->
-  case lists:member(StatusInt, [301, 302, 307]) of
+  case lists:member(StatusInt, [301, 302, 307, 308]) of
     true ->
       Transport:setopts(Socket, [{active, false}]),
       case parse(Client) of