Fix a memset that doesn't zero enough bytes. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristofferkoch
suggested changes
May 9, 2019
| @@ -8025,7 +8025,7 @@ int Abc_CommandExact( Abc_Frame_t * pAbc, int argc, char ** argv ) | |||
| if ( argc == globalUtilOptind ) | |||
| goto usage; | |||
|
|
|||
| memset( pTruth, 0, 64 ); | |||
| memset( pTruth, 0, 64 * sizeof(word) ); | |||
There was a problem hiding this comment.
I also got a warning for this while trying out gcc-9. However, is it more idiomatic with 64 * sizeof(pThruth[0])?
Of course, the 64 is not nice in itself, but one thing at the time :)
|
This seems to be addressed by #31 as well. |
|
Ah, you're right. I missed #31. You should probably merge that one and close this one. As for |
|
I'm just a random guy on the internet :) This project seems to not have any changes for a long time. Maybe it should be forked and maintained, e.g. by the yosys team? |
alanminko
approved these changes
May 10, 2019
|
This project is still active. Thank you for the pull request.
…On 5/10/2019 2:51 PM, Kristoffer Ellersgaard Koch wrote:
I'm just a random guy on the internet :) This project seems to not
have any changes for a long time. Maybe it should be forked and
maintained, e.g. by the yosys team?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI4DBXRZAHLMVTZ2LNBOCE3PUULNVANCNFSM4HLWLSHQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.