Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PhpProcess to run PHP script in isolation to verify exit() #1

Merged

Conversation

crynobone
Copy link

No description provided.

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@bert-w bert-w merged commit c23dc7b into bert-w:return-non-zero-exit-codes Mar 30, 2023
@crynobone crynobone deleted the return-non-zero-exit-codes branch September 20, 2023 00:37
bert-w pushed a commit that referenced this pull request Feb 27, 2024
…laravel#49474)

* test: validateJson should return false when value is null

Fails with Laravel Framework 10.38.2 in PHP < 8.3, introduced in laravel#49413

* fix: validateJson should return false when value is null

Return false when $value is null.

Avoid TypeError: json_validate(): Argument #1 ($json) must be of type string, null given, when using symfony/polyfill-php83 in PHP < 8.3.

Avoid deprecation warning: json_validate(): Passing null to parameter #1 ($json) of type string is deprecated, when using PHP 8.3.

---------

Co-authored-by: Rogelio Jacinto <rogelio@elabmexico.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants