Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Possible bug] Using correct java home in packaging tasks #142

Closed
fourlastor opened this issue Aug 1, 2023 · 1 comment
Closed

[Possible bug] Using correct java home in packaging tasks #142

fourlastor opened this issue Aug 1, 2023 · 1 comment

Comments

@fourlastor
Copy link
Contributor

While testing setting the java home via

runtime {
    javaHome.set("/path/to/preferred/java/home/different/from/project")
}

I had issues with running the JPackageTask, and I suspect it's due to how it gets the java home folder (which seems not to use BaseTask.getJavaHomeOrDefault()).

I think I have a fix here fourlastor-forks#1 but I haven't tested it (PR on my fork because I needed the fixes from the other PR and this was the simplest way to show the diff 😀)

I'm going to update this issue as soon as I get some time to test out the fix

@fourlastor
Copy link
Contributor Author

Closing as I opened #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant