Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BaseTask java home in jpackage tasks #143

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

fourlastor
Copy link
Contributor

This PR removes the java home in JPackageData and uses instead the one defined in BaseTask.

This is to fix an issue where specifying a different java home in the configuration doesn't apply to the jpackage task.

I tested it by using this branch and running the task test:packageWinX64 on Windows (which will run the jpackage task)

This requires to have a setup like the following:

/construo-gdx
    /jdk/jdk-17.0.8+7 (copy of jdk 17 here)
/badass-runtime-plugin

  1. The runtime plugin (included via composite builds in the project) requires Java 11 to be built (so the entire gradle project is running using java 11 by setting the gradle jvm in intellij)
  2. The jdk specified to the runtime plugin is 17

Checking out the master branch of the runtime plugin fails the build (as it tries to use the gradle jdk - 11, to run jpackage, which doesn't exist), while the fix branch succeeds

@fourlastor
Copy link
Contributor Author

@hakanai not sure if you saw this pr

Copy link
Collaborator

@hakanai hakanai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The option still seems to be there for the case where it's provided, but when not provided it falls back to what you'd expect it to anyway, so it looks right to me.

@hakanai
Copy link
Collaborator

hakanai commented Oct 10, 2023

@hakanai not sure if you saw this pr

I think I had, but I had a trip out of the country between seeing it and now, and I have been fighting to get on top of my email and other tasks since returning... 😅

@hakanai hakanai merged commit bec21b3 into beryx:master Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants