Fixed shading of the asm dependency

[arpsmack]

Removed the "plugin" configuration and reverted back to using the default configuration setting for the shadow plugin.

Added SLF4J to the shadow configuration so it doesn't get shaded. SLF4J is a super common dependency for a lot of libraries and has a very stable API.

[sirhcel]

Thank you for your fix @arpsmack! This brings packaging with JDK 17 back on track for me.

It required a fair bit of configuration to convince Gradle to use a custom hotfix release from a custom artifact repostitory in CI. According to the comments in #136, this fixes the issue for many. Could you please release this change @hakanai, so that it could be easily fetched from a public artifact repository?

[hakanai]

It's merged. As for releasing... I don't know how to do it yet. 😅

[sirhcel]

@siordache do see an issue with cutting a new release for getting this change into a public repository? You did the last one. Could you please help us here as well?

[siordache]

I configured the credentials for the Gradle Plugins Portal and added a GitHub action for publishing to it.

@hakanai You should be able now to do releases yourself:

• in gradle.properties set badassRuntimePluginReleaseBuild to true
• commit and push
• execute "Run workflow" on the Publish to the Gradle Plugin Portal GitHub action
• check if the new release is available in the Gradle Plugins Portal
• in gradle.properties increment badassRuntimePluginVersionPatch and set badassRuntimePluginReleaseBuild back to false
• commit and push

Give it a try!

[mavek87]

any news for the release?

[siordache]

Release 1.13.1 is out!

[hakanai]

Apologies for not getting on this one, but some major life issues are afoot and it’s awfully hard to keep up with mail.

…

On Thu, 22 Feb 2024 at 05:33, Serban Iordache ***@***.***> wrote: Release 1.13.1 is out! — Reply to this email directly, view it on GitHub <#147 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAKRZEELY7TSCLPRC7IMXLYUY4X5AVCNFSM6AAAAAA57KY366VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJXGY2TINJZGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>