Use specific Host class #26

[oneiros]

This should fix #26

Please see theforeman/foreman-packaging#10374 for all the details.

And take special notice of this comment here about a possible caveat.

[ekohl]

This is probably ok, but it made me wonder about a DB migration. Looking at the migration:

foreman_hdm/db/migrate/20230519125201_add_hdm_proxy_id_to_hosts.rb

Line 3 in 01454d0

add_column :hosts, :hdm_proxy_id, :integer

Shouldn't this use add_foreign_key? Probably with on_delete: :nullify.

Looking at https://api.rubyonrails.org/v7.1.3/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-add_foreign_key it's in addition to an add_column statement, so should be a new migration instead of changing the old one.

Still, that was an issue before this and still is one after. So 👍 to this.

[tuxmea]

@oneiros have you seen @ekohl 's comment?
Are we OK to merge this?

[oneiros]

Are we OK to merge this?

Yes. The comment is unrelated, but sensible. I added a separate PR here #28.