Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix setting hostname and port #257

Merged
merged 2 commits into from
Jan 10, 2024
Merged

fix setting hostname and port #257

merged 2 commits into from
Jan 10, 2024

Commits on Jan 10, 2024

  1. fix setting hostname and port 

    when using env vars in CMD, one must use `sh -c` to allow variable
evaluation
    @tuxmea
    tuxmea committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    55b6a69 View commit details
    Browse the repository at this point in the history

  2. we must exclude the shellcheck SC2086 

    reason: if we set the quoptes, the quotes will be also used by the
container.
the port must not have quotes.
    @tuxmea
    tuxmea committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    54a214f View commit details
    Browse the repository at this point in the history