Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more sec alerts #31

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Fix more sec alerts #31

merged 2 commits into from
Apr 7, 2022

Conversation

rwaffen
Copy link
Member

@rwaffen rwaffen commented Apr 7, 2022

No description provided.

bastelfreak
bastelfreak approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for a clean history I would prefer a rebase against main, instead of of the merge commit, but the changes itself look fine.

@rwaffen
Copy link
Member Author

rwaffen commented Apr 7, 2022

i dont like rebase, because if there is a conflict you might have to solve it several times. so i'm used to do a merge instead.

@rwaffen rwaffen merged commit fe6ccb8 into main Apr 7, 2022
@rwaffen rwaffen deleted the fix_more_sec_alerts branch April 7, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwaffen @bastelfreak